-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated deploy-docker.sh to docker compose v2 #129
updated deploy-docker.sh to docker compose v2 #129
Conversation
We require contributors/corporates @adirola to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document |
Hi thank you!!!^^ But didin't this PR breaks the compatibility with the previous docker compose version? |
@invocamanman yes this is a breaking change but most new users from july 2023 will only get docker compose v2. Based on this we can either restrict the docker-compose version in the repo documentation or create new script for version v2 so as to accommodate people using docker compose v2. To avoid breaking change have introduced it as new file for version 2 and have a new command in package.json. |
We require contributors/corporates @adirola to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document |
This actually seems better! thank you so much! |
Also pls correct the file name |
We require contributors/corporates @adirola to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document |
26b486a
to
fb84ab8
Compare
We require contributors/corporates @adirola to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document |
1 similar comment
We require contributors/corporates @adirola to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document |
bcc1a33
to
7e53619
Compare
We require contributors/corporates @adirola to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document |
Hey @invocamanman thanks for the guidance, as mentioned in comments i have updated the file name and squashed the commit into single commit. |
you should be added to the CLA, try to change a commit name or something to reset the bot pls^^ |
7e53619
to
3fae829
Compare
Done @invocamanman, i think its good to merge from my end. |
The current docker deployment script will not work with docker compose v2 installed and throws an error of unknown command "docker-compose"
Updated the script to docker compose v2
Issue: #128